I just upgraded then rooted.
Rooting ICS was fairly straight forward for me. I used Odin to install CWMR. Then used CMWR to install the appropriate zip from here Superuser
Whole thing took maybe 15 minutes.
Usual disclaimer: If you break your phone it is your problem. This is just a rough account of what I did. Your results may vary.