Thread: Support Donut on Galaxy
View Single Post
Old October 8th, 2009, 03:58 AM   #35 (permalink)
bitxboi
Member
 
Join Date: Aug 2009
Posts: 323
 
Device(s):
Thanks: 4
Thanked 6 Times in 6 Posts
Default

Quote:
Originally Posted by Russ Dill View Post
Ok, lets look at the kernel source. The first thing I notice is that it all as dos newlines. EPIC FAIL. The second thing that I notice is that they did not preserve case, so all the files in netfilter that are the same other than case are screwed up. Fail again. What did they do, check this into a windows based source control system? Oh, wait, they did CLEARCASE evidenced by the stgloc file. Yes my friends, the poor saps over at Samsung are actually doing kernel development via rational, and not even configured for unix clients it seems. Another consequence of this is that all permission bits are lost.

Its also very difficult to determine what work Samsung has done. Their tree appears to be based on an ancestor of:

https://www.codeaurora.org/gitweb/quic/le/?p=kernel/msm.git;a=summary

It looks like Samsung pulled from some internal Qualcomm tree, and Qualcomm later changed all the copyright headers and pushed the code to codeaurora. "Copyright (c) 2009, Code Aurora Forum. All rights reserved." vs "Copyright (c) 2009 QUALCOMM USA, INC."

Given where some code shows up, I don't think samsung understands the directory structure or code placement for the arm arch. Also interesting is that they don't seem to get what arch/arm/mach-*/board-* files are. They have a new board-battery.c, board-headset.c, board-init.c, board-keypad.c, board-param.c, board-rfkill.c, and board-rfkill1.c. To finish the irony, they do not have a board-capela., they just modified the base mach-msm files with a bunch of #if defined(CONFIG_SAMSUNG_CAPELA).

And lets not forget code that is non-gpl, eg, drivers/i2c/chips/smb300.c

* It is not allowed to deliver the source code of the Software to any third party without permission of
* Bosch Sensortec.
hmmmm...are you implying the kernel samsung built is actually crap?¿ Because every line I read from you comments seems like something is wrong everywhere and they've screwed it big time. The part that worries me the most is the one I bolded.
bitxboi is offline  
Reply With Quote