Root Work begins on the camera for CM7 variants!

[dsmryder]

This is the first post for the work I am doing.
Follow the normal CWM process. Flash the .zip, clear your cache. Reboot that bit.

I hope to make the camera as good as it needs to be for everybody.

I want people who want to walk with me to post what ROM they are using, version included. Any modified kernels. Any other pertinent information they think is useful.
Thank you and have fun.

 

[g60madman]

Do you have the source code for this on GitHub?

 

[dsmryder]

Do you have the source code for this on GitHub?

Yeah. I forked your line back in June. I have been having troubles in setting up my build rig to build my personal ROM and planned on working with some of the things that I thought were in need of work as I learn. I'm hoping that people will give me issues to track down while I read my SHtuff.

 

[Chairshot215]

One thing that was discovered is that the front Camera FC issue seemed to be related to Gapps and if the package used contained the gtalk/video package. Have not had a chance for much testing but it would seem to be what was going on with Starship.

 

[b_randon14]

My camera has been working fine. And its up to date with cm7 mainline gingerbread. And I also use the gtalk with video gapps.

The only problem I had with the camera was with the dcim compliant patch you pulled from mantera last month. I reverted it and everything works fine. Video and camera on front and back!! You all can check out my repo it should be kept up to date as I pull in ans merge every couple days.

 

[dsmryder]

My camera has been working fine. And its up to date with cm7 mainline gingerbread. And I also use the gtalk with video gapps.

The only problem I had with the camera was with the dcim compliant patch you pulled from mantera last month. I reverted it and everything works fine. Video and camera on front and back!! You all can check out my repo it should be kept up to date as I pull in ans merge every couple days.

What's wrong with the DCIM compliance? Was that the exif data errors? My exif data is correct for the test pictures I took.

 

[b_randon14]

No it broke the camera completely! It would just freeze when trying to connect to the camera hardware!

 

[dsmryder]

No it broke the camera completely! It would just freeze when trying to connect to the camera hardware!

Wierd. I built the app just as it's seen on my github. I know I have taken just a couple of pics, but they all came out fine. Could it be an incampatability with something else (gapps thing), like has been mentioned on chairshot's thread?

 

[b_randon14]

Yeah I know it sure broke my camera! Is your up to date with cm7 upstream? I believe iI have pulled in all the changes on mine. It works great and both front and rear camera work great and take movies as well.

Also the dcim patch made it rename and reorganize all my pictures which I didnt like!! But I am still unknowing of the issues we have with the cm7 camera. Mine works fine. Never really had any issues pulling in upstream changes either!!

 

[dsmryder]

Yeah I know it sure broke my camera! Is your up to date with cm7 upstream? I believe iI have pulled in all the changes on mine. It works great and both front and rear camera work great and take movies as well.

Also the dcim patch made it rename and reorganize all my pictures which I didnt like!! But I am still unknowing of the issues we have with the cm7 camera. Mine works fine. Never really had any issues pulling in upstream changes either!!

I'll tell you the truth. I only forked the camera back in June and haven't touched it sence. Sence then, in the g60style thread, the camera somehow got broken, got relisted in the default.xml (I think) to tickerguy's, and so on. I had the fork right after the DCIM update and haven't picked up anything else.

I planned on doing a community ROM sence G60 said he was leaving for mobstergun's ROM and I prefer the options in CM7. But no body came and said they wanted to lear to build in that thread, so I let it die.

I have taken a small bunch of pictures and videos and what I have listed on my github works as well as I would want it to. If someone wanted a feature in an update, I would try and make it work. Lately I have been playing with the DeskClock. Seeing what extra items I can add and make it my own. You know?

 

[b_randon14]

Yeah I thought that maybe somehow the camera had gotten messed up in g60's repos. You are only like to commits behind upstream and one is just Dutch translations. I may mess around and try to get that dcim patch working right eventually. But yeah I seen where you had been messing with the desk clock. I would like to add stuff like in alarm clock plus. Mainly the alarm clock features! I just don't know Java too well enough to add in stuff like that!

 

[dsmryder]

Yeah I thought that maybe somehow the camera had gotten messed up in g60's repos. You are only like to commits behind upstream and one is just Dutch translations. I may mess around and try to get that dcim patch working right eventually. But yeah I seen where you had been messing with the desk clock. I would like to add stuff like in alarm clock plus. Mainly the alarm clock features! I just don't know Java too well enough to add in stuff like that!

I hope I'm adding the buttons in a verticle orientation instead of side by side. From there, I'll work on the button size.

 

[Chairshot215]

Whats crazy is I could never reproduce it either until I used the posted G Apps as I just copied the link from the CM7 thread when I posted but was using another package. With this said I built with b_randon14's Camera and it worked on both packages. I added the images in and the front Camera stopped working with the posted package again. What I did was build once with the images and then again without. I opened up both APK's as an archive with 7zip and did a drag and drop of the images from the one into the other. I built again using the APK I copied the images into and it seems to be working fine for everyone. Would really need to look at this further with more testing because I cant for the life of me understand how an edited image could cause an issue determined by what Gapps package is used. I have seen images if sized incorrectly cause a Force Close and I have checked the focus image and a few others but how this plays into the Gapps thing is beyond me. Could all just be crazy coincidences.

 

[dsmryder]

Whats crazy is I could never reproduce it either until I used the posted G Apps as I just copied the link from the CM7 thread when I posted but was using another package. With this said I built with b_randon14's Camera and it worked on both packages. I added the images in and the front Camera stopped working with the posted package again. What I did was build once with the images and then again without. I opened up both APK's as an archive with 7zip and did a drag and drop of the images from the one into the other. I built again using the APK I copied the images into and it seems to be working fine for everyone. Would really need to look at this further with more testing because I cant for the life of me understand how an edited image could cause an issue determined by what Gapps package is used. I have seen images if sized incorrectly cause a Force Close and I have checked the focus image and a few others but how this plays into the Gapps thing is beyond me. Could all just be crazy coincidences.

I'm a little confused on what you did. You added your images from your ROM to b_random's as a test? And you are testing this against the updated gapps?

 

[Chairshot215]

I'm a little confused on what you did. You added your images from your ROM to b_random's as a test? And you are testing this against the updated gapps?

I built with b_random's and it worked fine on both gapps packages. I then added in my images in the next build and it crashed on the front cam again with the posted Gapps package. I repeated the process with G60's code and had the same result. I then basically just used 7zip to transfer my images from the broken APK into the working APK. I tested it a bit then put the APK in the device tree and put in a line to copy it over in the Triumph.mk. Its been a few days now and I haven't heard anything about it force closing. I think it may be one of my images causing the issue but am confused on how the Gapps thing could be a factor. I had used it myself with the images for weeks and had not had an issue until I changed up the package. Was otherwise kind of sceptical on the Gapps being able to cause the issue. Granted I wasn't taking very many pictures of myself until the issue had been pointed out.

 

[dsmryder]

I built with b_random's and it worked fine on both gapps packages. I then added in my images in the next build and it crashed on the front cam again with the posted Gapps package. I repeated the process with G60's code and had the same result. I then basically just used 7zip to transfer my images from the broken APK into the working APK. I tested it a bit then put the APK in the device tree and put in a line to copy it over in the Triumph.mk. Its been a few days now and I haven't heard anything about it force closing. I think it may be one of my images causing the issue but am confused on how the Gapps thing could be a factor. I had used it myself with the images for weeks and had not had an issue until I changed up the package. Was otherwise kind of sceptical on the Gapps being able to cause the issue. Granted I wasn't taking very many pictures of myself until the issue had been pointed out.

So wait. If it was your images, then wouldn't moving the images with 7zip cause the problem images to follow the images?
I had a problem with my dsmryderaudio.mk. I was able to build until I realized that I didn't have a phone ringetone. So I copied and pasted some from another audiopack and because the file ended with a continue "/" symble.
I wonder if you may have a syntax error with the image changes.

 

[Chairshot215]

So wait. If it was your images, then wouldn't moving the images with 7zip cause the problem images to follow the images?
I had a problem with my dsmryderaudio.mk. I was able to build until I realized that I didn't have a phone ringetone. So I copied and pasted some from another audiopack and because the file ended with a continue "/" symble.
I wonder if you may have a syntax error with the image changes.

I'm pretty sure its something to do with an image and not sure why moving them over with 7zip fixed it. At some point I will need to check them out individuality or build in groups to narrow it down. I have already checked the obvious ones like focus.

Only thought to add in the images with 7zip because I figured it would brake the working APK and I could then be sure it was an issue with an image. Wasn't trying to find a fix, was actually on my lunch brake and thought it would be a quick way of testing a theory.